Open
Conversation
When searching the branch for the commitId, use pagination to search more commits
meeroslav
requested changes
Nov 12, 2025
Collaborator
meeroslav
left a comment
meeroslav
left a comment
There was a problem hiding this comment.
The current solution doesn't work.
Can you replace it with a suggested async iterator and build the code so that the PR contains both source and the dist files?
Thanks!
Refactor commit existence check to use async iterator for pagination.
meeroslav
reviewed
Jan 29, 2026
meeroslav
requested changes
Jan 29, 2026
Collaborator
meeroslav
left a comment
meeroslav
left a comment
There was a problem hiding this comment.
There a typo when referencing the propery name in nx-set-shas.ts
Author
|
Typo fixed - apologies, should have had my coffee first I think |
Author
|
@meeroslav - Anything else you need from me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching the branch for the commitId, use pagination to search more commits
Fixes #144